Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remap noise model utility function #190

Merged
merged 6 commits into from
Apr 30, 2019
Merged

Remap noise model utility function #190

merged 6 commits into from
Apr 30, 2019

Conversation

chriseclectic
Copy link
Member

@chriseclectic chriseclectic commented Apr 30, 2019 •
edited
Loading

Summary

  • Adds a qubit reampper utility function for NoiseModels: remap_noise_model (generalizes @nonhermitian function in reduced_basic_noise_model #181)
  • Adds __eq__ method to NoiseModel, QuantumError, ReadoutError
  • Cleans up how errors are stored inside noise model so that errors are composed into a single error rather than stored as a list. This should help with simulation efficiency.
  • Adds additional noise model tests

Details and comments

@chriseclectic chriseclectic requested a review from atilag as a code owner April 30, 2019 16:29
@nonhermitian nonhermitian mentioned this pull request Apr 30, 2019
Closed
@chriseclectic chriseclectic force-pushed the feature/reduced-noise-model branch from a49d579 to 88ce445 Compare April 30, 2019 19:36
@chriseclectic chriseclectic changed the title [WIP] Remap noise model utility function Remap noise model utility function Apr 30, 2019
@chriseclectic chriseclectic merged commit 8ad5f47 into Qiskit:master Apr 30, 2019
@chriseclectic chriseclectic deleted the feature/reduced-noise-model branch April 30, 2019 20:13
dcmckayibm pushed a commit to dcmckayibm/qiskit-aer that referenced this pull request Nov 3, 2019
@chriseclectic
Remap noise model utility function (Qiskit#190)
c7d50d5 
* rework how errors are stored internally in noise model

* add remap_noise_model

* add __eq__ to NoiseModel and errors

* add additional noise tests

* add remap_noise_model tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

@atilag atilag Awaiting requested review from atilag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chriseclectic