Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for unreleased Qiskit #1950

Merged
merged 12 commits into from
Oct 19, 2023
Merged

Add test for unreleased Qiskit #1950

merged 12 commits into from
Oct 19, 2023

Conversation

doichanj
Copy link
Collaborator

@doichanj doichanj commented Sep 29, 2023 •
edited
Loading

Summary

This PR is preparation for unreleased Qiskit to implement changes and remove deprecations (#1941 )

Details and comments

New test case unit-tests-latest-qiskit-terra is used to detect changes in the latest Qiskit and if any deprecation error found, this PR should be updated

Change logs:
bind_parameters is replaced with assign_parameters
QuantumCircuit.i() is replaced with QunatumCircuit.i() by PR #1945

@doichanj doichanj added Changelog: Deprecation Include in Deprecated section of changelog Changelog: API Change Include in the Changed section of the changelog labels Sep 29, 2023
@doichanj doichanj added this to the Aer 0.13.0 milestone Sep 29, 2023
@doichanj doichanj self-assigned this Sep 29, 2023
mtreinish
mtreinish reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea, we had this coverage in the past where tests ran with terra main on each job. But blocking PRs on terra main was a bit too disruptive at the time (just from a dependency management PoV). So adding a dedicated job back to ensure we have some coverage of upcoming changes to terra is a good idea, especially if we do it in a non-blocking manner. The open question I have is mostly about the long term strategy for how/when we run this job.

.github/workflows/tests.yml Outdated
Comment on lines 283 to 290
unit-tests-latest-qiskit-terra:
runs-on: ${{ matrix.os }}
needs: [sdist, lint]
timeout-minutes: 60
strategy:
matrix:
python-version: ["3.11"]
os: ["ubuntu-latest"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you thinking we should run this on every commit? Or was the eventual plan to run this job periodically when it's no longer a WIP? We can set this up in a new workflow file and create a nightly cron job to run this test if we want to do it periodically, see: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to use this test case for testing deprecations and changes of Qiskit. I will remove this test case and only merge fixes in this PR.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@1ucian0
Copy link
Member

1ucian0 commented Oct 3, 2023

The open question I have is mostly about the long term strategy for how/when we run this job.

Other components run it daily:

@doichanj doichanj mentioned this pull request Oct 10, 2023
Closed
@doichanj doichanj changed the title [WIP] Add test for unreleased Qiskit Add test for unreleased Qiskit Oct 19, 2023
@mtreinish mtreinish added Changelog: None PRs that don't have an associated changelog entry. automerge This PR will automatically merge once its CI has passed and removed Changelog: Deprecation Include in Deprecated section of changelog Changelog: API Change Include in the Changed section of the changelog labels Oct 19, 2023
@mergify mergify bot merged commit e7afbfb into Qiskit:main Oct 19, 2023
32 checks passed
doichanj added a commit to doichanj/qiskit-aer that referenced this pull request Oct 26, 2023
@doichanj @mtreinish
Add test for unreleased Qiskit (Qiskit#1950)
77ca57c 
* add tests for unreleased Qiskit

* Update .github/workflows/tests.yml

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

* Scheduled test for latest Qiskit

* run latest Qiskit test at push

* fix test

* fix qiskit test again

* fix test case for runtime parameter binding

* remove on push/pull request from latest Qiskit unit test

---------

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees

@doichanj doichanj

Labels
automerge This PR will automatically merge once its CI has passed Changelog: None PRs that don't have an associated changelog entry.
Projects
None yet
Milestone
Aer 0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@doichanj @1ucian0 @mtreinish