-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Store
and storage Var
#2028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that assignment of |
this was resolved. |
hhorii
changed the title
[WIP] Support
Support May 9, 2024
Store
and storage Var
Store
and storage Var
hhorii
force-pushed
the
support_var_storage
branch
from
May 21, 2024 04:24
e4901e8
to
aa9a52f
Compare
hhorii
force-pushed
the
support_var_storage
branch
from
May 21, 2024 06:24
aa9a52f
to
cef174e
Compare
doichanj
reviewed
May 22, 2024
setup.py
Outdated
@@ -22,7 +22,7 @@ | |||
extras_requirements = {"dask": ["dask", "distributed"]} | |||
|
|||
requirements = [ | |||
"qiskit>=0.45.2", | |||
"qiskit>=1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have to discuss if we can remove support for older Qiskit
doichanj
added
the
Changelog: New Feature
Include in the Added section of the changelog
label
May 23, 2024
doichanj
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support
Store
andVar
as storage, which will be released in Qiskit 1.0Details and comments
This PR adds support of
Store
andVar
as storage. This PR requires Qiskit 1.0 and will not be merged until its release.AerStore
is an ad-hoc solution for transpilation issue ofStore
. Currently,Store
is not supportedtranspile()
and can be moved to an inappropriate position after transpilation. By using an custom instructionAerStore
, this PR prevents from movingStore
.