Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Store and storage Var #2028

Merged
merged 13 commits into from
Jun 17, 2024
Merged

Conversation

hhorii
Copy link
Collaborator

@hhorii hhorii commented Jan 12, 2024

Summary

Support Store and Var as storage, which will be released in Qiskit 1.0

Details and comments

This PR adds support of Store and Var as storage. This PR requires Qiskit 1.0 and will not be merged until its release.

AerStore is an ad-hoc solution for transpilation issue of Store. Currently, Store is not supported transpile() and can be moved to an inappropriate position after transpilation. By using an custom instruction AerStore, this PR prevents from moving Store.

@hhorii
Copy link
Collaborator Author

hhorii commented Jan 23, 2024

I found that assignment of Var with Var fails.

@hhorii
Copy link
Collaborator Author

hhorii commented May 9, 2024

I found that assignment of Var with Var fails.

this was resolved.

@hhorii hhorii changed the title [WIP] Support Store and storage Var Support Store and storage Var May 9, 2024
@hhorii hhorii requested a review from doichanj May 9, 2024 05:38
@hhorii hhorii force-pushed the support_var_storage branch from e4901e8 to aa9a52f Compare May 21, 2024 04:24
@hhorii hhorii force-pushed the support_var_storage branch from aa9a52f to cef174e Compare May 21, 2024 06:24
setup.py Outdated
@@ -22,7 +22,7 @@
extras_requirements = {"dask": ["dask", "distributed"]}

requirements = [
"qiskit>=0.45.2",
"qiskit>=1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to discuss if we can remove support for older Qiskit

@doichanj doichanj added this to the Aer 0.15.0 milestone May 23, 2024
@doichanj doichanj added the Changelog: New Feature Include in the Added section of the changelog label May 23, 2024
@doichanj doichanj merged commit 9a4f283 into Qiskit:main Jun 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants