Parallelize sampling measure #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
enhancement
hhorii
previously approved these changes
Feb 20, 2024
|
Just FYI. The reason why |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes performance of sampling measure #2021 by
Details and comments
This PR adds new basic class
BitVectorto store bit counts obtained by sampling measure.Bits counts were stored as array of 64-bits integer previously that wastes large memory space and memory bandwidth.
BitVectorhas a variable length bit string that requires fewer memory.(
BitVectorcan be used for stabilizer method, but not included in this PR)There were some loops not parallelized before:
are now parallelized by OpenMP.