-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable sampling for readout error #222
Conversation
I think it would be good to have the noise model objects to have methods that return True/False to check for readout errors, local quantum errrors, and non-local quantum errors (this will also be useful for optimisation passes later)
Then in this PR you could replace for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @hhorii, could you fix the conflicts and update CHANGELOG and then we can merge
552c297
to
8c967fd
Compare
* enable sampling for readout error * fix a bug in noise-model sampling.
Summary
This PR adds support of sampling for read-out errors in qasm simulator.
Details and comments
Currently, qasm simulator enables sampling if
noise_model.ideal()
returnstrue
, andThis PR will change as follows:
noise_model.ideal()
ornoise_model.only_readout_errors()
returnstrue
, andall the measure and readout-error operations are the bottom in a circuit.
Implement this feature
Add tests