Remove deprecated warning from Terra and change our as_dict() to to_dict() #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Deprecating our as_dict() methods in favor of to_dict()
* Add entry in the Changelog
* Removing a print from a test
chriseclectic
approved these changes
Jun 6, 2019
gadial
pushed a commit
to gadial/qiskit-aer
that referenced
this pull request
Jun 11, 2019
…ict() (Qiskit#228) * * Removing deprecation warnings from Terra by using to_dict() * Deprecating our as_dict() methods in favor of to_dict() * * Add helpers.py new file * Add entry in the Changelog * * Fixing a bad tuple * Removing a print from a test
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
…ict() (Qiskit#228) * * Removing deprecation warnings from Terra by using to_dict() * Deprecating our as_dict() methods in favor of to_dict() * * Add helpers.py new file * Add entry in the Changelog * * Fixing a bad tuple * Removing a print from a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #227
Details and comments
We have changed all our as_dict() methods from the API to keep consitency with Terra, as we needed to change
NoiseModelat least.I have created a new Python helper class where we can put our global helper functions.
TODO