Noise model inserter #239
Merged
Noise model inserter #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick update - testing cannot proceed due to a blocker bug in Terra, Qiskit/qiskit#2751. |
There was a problem hiding this comment.
This looks good @gadial, just a couple of minor changes to some names and if you could add something to the CHANGELOG then it should be good to merge!
It might be good to add a couple of tests using the DensityMatrix class recently merged into Terra master too.
chriseclectic
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A utility addressing issue #212 : Inserting to a circuit Kraus gates representing the noises from a given noise model.
Details and comments