Refactor and improve fusion #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilag
reviewed
Jun 27, 2019
| @@ -29,7 +29,7 @@ using reg_t = std::vector<uint_t>; | |||
|
|
|||
| class Fusion : public CircuitOptimization { | |||
There was a problem hiding this comment.
We need some code documentation here.
What is Fusion?
There was a problem hiding this comment.
In general, we have to document every method in this class
| @@ -510,6 +510,15 @@ std::vector<T> vectorize_matrix(const matrix<T>& mat) { | |||
| return vec; | |||
| } | |||
|
|
|||
| template<class T> | |||
| std::vector<T> vectorize_diagonal_matrix(const matrix<T>& mat) { | |||
There was a problem hiding this comment.
This function actually just extracts the diagonal from a square matrix, so maybe we should call it matrix_diagonal. I won't let it block this PR though, I can rename in cu1 gates PR.
chriseclectic
approved these changes
Jul 3, 2019
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* refactor fusion by deleting matrix_sequence and fix bugs in mcu in qubitvector. * CH supports nop * specialize u1 and cu1 fusion * refactor fusion-related codes * remove nop operation type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors and improves fusion optimization.
Details and comments
Transpile::Fusiongenerates a matrix.matrix_sequenceis deprecated fromOpType.QV::QubitVectorspecializes some 2qubit operations with matrixes.