Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max_workers parameter to ThreadPoolExecutor in AerJob #259

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

hitomitak
Copy link
Contributor

Summary

To fix #244.

Details and comments

Add max_workers parameter to ThreadPoolExecutor in AerJob. If this value is not set, AerJob creates threads endlessly.

@atilag
Copy link
Member

atilag commented Jul 2, 2019

So after talking with @hitomitak, we have decided to put max_workers = 1. That makes a lot of sense since the C++ part of Aer should be using all the CPU cores at their maximum capacity because of the nature of the simulation (CPU Bound). So we shall not allow more than 1 instance running locally, otherwise the performance will suffer, especially with larger simulations. For short simulations I guess that the only way to check that this hypothesis is true, is by testing... in the meantime, we are setting max_workers to 1.

@atilag atilag merged commit d32cbf6 into Qiskit:master Jul 2, 2019
dcmckayibm pushed a commit to dcmckayibm/qiskit-aer that referenced this pull request Nov 3, 2019
Set max_workers parameter to ThreadPoolExecutor in AerJob
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qiskit Aer has a memory leak
2 participants