Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reuse in azure pipelines and split build out #260

Merged
merged 6 commits into from
Jul 3, 2019

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented Jul 3, 2019

Summary

In the azure pipelines runs for #258 the jobs are failing for what looks
like a mismatch with the installed aer python package and what should
have been built. Just to rule that out for runs this commit makes 2
changes. First it creates a conda environment/virtualenv with a unique
name for each run. Secondly it runs git clean to remove any old built
wheels (assuming there are any). This turned out not to be the cause
of the failure, but it still doesn't hurt to just rule this out in future builds
anyway. To fix the underlying issue this commit splits the test running
from the aer build into a separate stage in the job. It also changes the
pip command invocation to only install locally and not fallback to use
pypi if a wheel isn't built.

Details and comments

In the azure pipelines runs for Qiskit#258 the jobs are failing for what looks
like a mismatch with the installed aer python package and what should
have been built. Just to rule that out for runs this commit makes 2
changes. First it creates a conda environment/virtualenv with a unique
name for each run. Secondly it runs git clean to remove any old built
wheels (assuming there are any). Hopefully this will provide more
reliability in future runs.
@mtreinish
Copy link
Member Author

These steps aren't actually needed to fix #258 (but they don't hurt). It looks like the jobs are failing there because the wheel build fails. But it apparently doesn't exit non-zero and our pypi command is falling back to install aer from pypi. I'm going to update this to change pip to only install locally. We should also figure out why the build fails.

@mtreinish mtreinish changed the title Avoid reuse in azure pipelines job configuration Avoid reuse in azure pipelines and split build out Jul 3, 2019
Copy link
Member

@chriseclectic chriseclectic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtreinish !

@chriseclectic chriseclectic merged commit 3d4106c into Qiskit:master Jul 3, 2019
@mtreinish mtreinish deleted the fix-azure branch July 3, 2019 16:13
dcmckayibm pushed a commit to dcmckayibm/qiskit-aer that referenced this pull request Nov 3, 2019
* Avoid reuse in azure pipelines job configuration

In the azure pipelines runs for Qiskit#258 the jobs are failing for what looks
like a mismatch with the installed aer python package and what should
have been built. Just to rule that out for runs this commit makes 2
changes. First it creates a conda environment/virtualenv with a unique
name for each run. Secondly it runs git clean to remove any old built
wheels (assuming there are any). Hopefully this will provide more
reliability in future runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants