Snapshot circuit extensions #317
Conversation
test test test test test test test test test test test test test
typo in test test test fixes uncommenting important things test test test tidying up renaming files; testing density_matrix snapshot renamed file renamed file small typo fix fixed import in __init__.py
|
@kanejess To match terra I would suggest making a separate file for each type of snapshot and placing them inside |
|
Hi @kanejess , what is left to remove the [WIP]?. We targeted this to be included in 0.3 release which will happen very soon. |
There was a problem hiding this comment.
This looks better! Once you have address these changes I think we can remove the [WIP]. Also can you take a look at the linting, as that has failed on Travis.
|
There's a lot of code repetition in this PR, and other things that could be simplified, but that would probably require a deep redesign on how snapshots are implemented so I'm not going to postpone it as far as it works. |
|
I'd need confirmation from @kanejess for tomorrow to include this in the release. |
kanejess
changed the title
* Adding SnapshotStatevector and tests * Adding StabilizerSnapshot and tests * Adding SnapshotDensityMatrix and tests * Adding SnapshotExpectationValue and tests
Summary
Getting started on #300 - i.e. improving usability of different snapshot types.
Details and comments
Subclasses and methods written for
SnapshotStatevector#301,SnapshotStabilizer#302,SnapshotDensityMatrix#303,SnapshotProbabilities#304, andSnapshotExpectationValue#305.So far, tests are only checking that the snapshots have been created, and do not check that snapshot data is correct.
Still needs fixing:
'density_matrix'test gives error'ERROR: Circuit contains invalid instructions ( invalid snapshot instructions: {density_matrix})'