[WIP] Integrate open pulse cython into the build system #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating the old cyhton modules
…into openpulse-1
Closed
dcmckayibm
pushed a commit
to dcmckayibm/qiskit-aer
that referenced
this pull request
Nov 3, 2019
* Adding CMakeLists.txt to new cython files from OpenPulse * Simplified CMakeLists to build all the Cython related stuff * Removing unnecessary init python files * Adding CMake helper files * Add init files for Cython imports * Adding pulse_sim.py example, extracted from the already existing Notebook code
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Adding CMakeLists.txt to new cython files from OpenPulse * Simplified CMakeLists to build all the Cython related stuff * Removing unnecessary init python files * Adding CMake helper files * Add init files for Cython imports * Adding pulse_sim.py example, extracted from the already existing Notebook code
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Adding CMakeLists.txt to new cython files from OpenPulse * Simplified CMakeLists to build all the Cython related stuff * Removing unnecessary init python files * Adding CMake helper files * Add init files for Cython imports * Adding pulse_sim.py example, extracted from the already existing Notebook code
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Adding CMakeLists.txt to new cython files from OpenPulse * Simplified CMakeLists to build all the Cython related stuff * Removing unnecessary init python files * Adding CMake helper files * Add init files for Cython imports * Adding pulse_sim.py example, extracted from the already existing Notebook code
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Adding CMakeLists.txt to new cython files from OpenPulse * Simplified CMakeLists to build all the Cython related stuff * Removing unnecessary init python files * Adding CMake helper files * Add init files for Cython imports * Adding pulse_sim.py example, extracted from the already existing Notebook code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrating all the Cython files that are being originally compiled in the
setup.pyinto the CMake build system.Details and comments
As part of the integration, I have refactored the current cython integration in CMake to make it less verbose and simpler to use
TODO