Update device noise model to use gate_length #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atilag
reviewed
Sep 20, 2019
| @@ -96,7 +97,8 @@ def gate_time_values(properties): | |||
| name = gate.gate | |||
| qubits = gate.qubits | |||
| value = None # default value | |||
| params = _check_for_item(gate.parameters, 'gate_time') | |||
| params = _check_for_item(gate.parameters, 'gate_time') # deprecated | |||
There was a problem hiding this comment.
This is useless, right? The line behind will always overwrite params
There was a problem hiding this comment.
Yeah you're right, should be a different variable name
There was a problem hiding this comment.
Since this wasn't actually used in old version of backends I'll just remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Most) Devices now return gate timing information in their properties under the key
"gate_length". Previously the device noise model was looking for"gate_time"key. This updates the device noise model to use the correct name.It also renames the kwarg for adding custom gate times to
gate_lengthsand adds a deprecation warning if someone uses the oldgate_timeskwargCloses #336
Details and comments