Fix snapshot density matrix #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change density matrix from singleshot to average snapshot * if circuit contains density matrix snapshot it must default to density matrix method * adds State name to error message for invalid circuit instructions
* Add missing switch statement for manually selecting "statevector" qasm method
chriseclectic
force-pushed
the
snapshot-densmat
branch
from
e28c62a to
09d5e29
Compare
atilag
approved these changes
Oct 3, 2019
| Statevector::State<QV::QubitVector<float>> state; | ||
| validate_state(state, circ, noise_model, true); | ||
| } else { | ||
| Statevector::State<QV::QubitVector<>> state; |
There was a problem hiding this comment.
I think it's clearer if we explicitily say:
Suggested change
| Statevector::State<QV::QubitVector<>> state; | |
| Statevector::State<QV::QubitVector<double>> state; |
| if (validate) { | ||
| if (simulation_precision_ == Precision::single_precision) { | ||
| Statevector::State<QV::QubitVector<float>> state; | ||
| validate_state(state, circ, noise_model, true); |
There was a problem hiding this comment.
We can move this validate_state() right after the en of the conditional, because both branches of the conditional call the same function with the same args.
There was a problem hiding this comment.
the state arg is actually different (template param <float> or <double>);
| return Method::statevector; | ||
| } | ||
| // If circuit contains invalid instructions for statevector throw a hail | ||
| // mary and try for density matrix. |
| @@ -30,6 +30,10 @@ | |||
| snapshot_state_pre_measure_statevector_nondeterministic, | |||
| snapshot_state_post_measure_statevector_nondeterministic) | |||
|
|
|||
| def get_snapshots(data, label, snapshot_type): | |||
| """Format snapshots as list of Numpy arrays""" | |||
There was a problem hiding this comment.
I think this has one more level of indentation, right?
There was a problem hiding this comment.
Will merge here and fix in #380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes density matrix snapshot and adds tests.
Closes #303
Blocked by #355Details and comments