Switch cvxopt usage to cvxpy #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the usage of cvxopt to use cvxpy instead.
|
It looks like a numpy release earlier today is causing the python 3.5 failure on windows. |
|
@mtreinish how can we make test pass? |
I'm hoping it was just a temporary packaging issue because of the new version that would sort itself today. If that doesn't work we can just set a cap on the python 3.5 job. |
This reverts commit 27d3062.
This reverts commit c862c6d.
The last numpy version with 3.5 support is below the minimum version of numpy that cvxpy requires. This leads to a situation where we try updating the conda install numpy with pip, and that causes things to break. This isn't an issue on python >=3.6 because the conda packages for numpy are kept up to date.
|
I was actually wrong as to the root cause, it was an artifact of conda vs pip. I wrote down the details of what's going on in: bde0e77 Hopefully that will work, I seem to remember that we needed to conda install numpy to get aer to compile in the windows jobs, but we'll see if that's an issue I guess. |
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit switches the usage of cvxopt to use cvxpy instead.
Details and comments