Removed noise_model and sim_config as an argument in the pulse simulator
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eintroduced at some point?)
…m_config it is only causing super()._validate
chriseclectic
approved these changes
Jan 6, 2020
| """ | ||
|
|
||
| # Warnings that don't stop execution | ||
| warning_str = '{} are an untested feature, and therefore may not behave as expected.' | ||
| if noise_model is not None: | ||
| warn(warning_str.format('Noise models')) |
There was a problem hiding this comment.
I think we should keep the noise model as a warning for now
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
…mulator (Qiskit#503) * removed noise_model from digest args, and also sim_config handling * Changed warnings in digest for persistentValue pulses * multiplying qubit_lo_freq by 1e9 in digest.py, as assemble divides it by 1e9
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
…mulator (Qiskit#503) * removed noise_model from digest args, and also sim_config handling * Changed warnings in digest for persistentValue pulses * multiplying qubit_lo_freq by 1e9 in digest.py, as assemble divides it by 1e9
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
…mulator (Qiskit#503) * removed noise_model from digest args, and also sim_config handling * Changed warnings in digest for persistentValue pulses * multiplying qubit_lo_freq by 1e9 in digest.py, as assemble divides it by 1e9
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
…mulator (Qiskit#503) * removed noise_model from digest args, and also sim_config handling * Changed warnings in digest for persistentValue pulses * multiplying qubit_lo_freq by 1e9 in digest.py, as assemble divides it by 1e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As it won't be supported, removed
noise_modelargument from the pulse simulator backend, as well as thedigestfile. It can still be passed and detected throughbackend_options, but anAerErrorwill now be raised.In addition:
sim_confighas been removed; any options should be passed throughbackend_optionsAerError