Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depol error param for device noise model with depol + relaxation error #704

Merged
merged 7 commits into from
Apr 20, 2020

Conversation

chriseclectic
Copy link
Member

@chriseclectic chriseclectic commented Apr 17, 2020

Summary

Fixes #703

Details and comments

Running example code in issue 703 now returns:

Gate Infidelities (relax + depol, depol, relax)
id[0] = [0.00076, 0.00042, 0.00076]
u2[0] = [0.00076, 0.00042, 0.00076]
u3[0] = [0.00152, 0.00085, 0.00152]
id[1] = [0.00041, 0.00041, 0.00014]
u2[1] = [0.00041, 0.00041, 0.00014]
u3[1] = [0.00083, 0.00083, 0.00029]
id[2] = [0.00045, 0.00045, 0.00014]
u2[2] = [0.00045, 0.00045, 0.00014]
u3[2] = [0.0009, 0.0009, 0.00028]
id[3] = [0.00057, 0.00057, 0.0002]
u2[3] = [0.00057, 0.00057, 0.0002]
u3[3] = [0.00115, 0.00115, 0.0004]
id[4] = [0.00061, 0.00061, 0.00036]
u2[4] = [0.00061, 0.00061, 0.00036]
u3[4] = [0.00122, 0.00122, 0.00071]
cx[0, 1] = [0.01053, 0.00789, 0.01053]
cx[1, 0] = [0.01159, 0.00789, 0.01159]
cx[1, 2] = [0.00754, 0.00754, 0.00218]
cx[1, 3] = [0.01122, 0.01122, 0.0058]
cx[2, 1] = [0.00754, 0.00754, 0.00252]
cx[3, 1] = [0.01122, 0.01122, 0.00539]
cx[3, 4] = [0.00755, 0.00755, 0.00509]
cx[4, 3] = [0.00755, 0.00755, 0.00575]

So the relax + depol error is approx equal to the max error of the depol only or relax only error case.

@chriseclectic chriseclectic added this to the Aer 0.5.1 milestone Apr 17, 2020
@chriseclectic chriseclectic requested a review from atilag as a code owner April 17, 2020 17:31
@chriseclectic chriseclectic force-pushed the fix/device-gate-errors branch from e8696b0 to 6e1f34a Compare April 18, 2020 00:24
@chriseclectic chriseclectic added the stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable label Apr 18, 2020
@chriseclectic chriseclectic merged commit 4846841 into Qiskit:master Apr 20, 2020
chriseclectic added a commit to chriseclectic/qiskit-aer that referenced this pull request Apr 20, 2020
…error (Qiskit#704)

* Fix incorrect units for computing combined depol+relaxation error

* Fix bug in QuanutmError.compose

* Add checks, warnings, and truncation for invalid device noise parameters
@chriseclectic chriseclectic deleted the fix/device-gate-errors branch April 28, 2020 19:19
@chriseclectic chriseclectic added the Changelog: Bugfix Include in the Fixed section of the changelog label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Depolarizing error is not being applied in device noise model with thermal relaxation errors
2 participants