Fix required memory checks for QasmSimulator with custom method #763
Conversation
chriseclectic
added
Changelog: Bugfix
| @@ -352,12 +352,8 @@ template <class densmat_t> | |||
| size_t State<densmat_t>::required_memory_mb(uint_t num_qubits, | |||
| const std::vector<Operations::Op> &ops) | |||
| const { | |||
| // An n-qubit state vector as 2^n complex doubles | |||
| // where each complex double is 16 bytes | |||
| (void)ops; // avoid unused variable compiler warning | |||
There was a problem hiding this comment.
This is not part of your changes, but seeing this line, it makes clear that we need an override of this method.
| --- | ||
| fixes: | ||
| - | | ||
| Fixes issue where memory requirements of simulation were not being checked | ||
| on the QasmSimulator when using a non-automatic simulation method. |
There was a problem hiding this comment.
I thought this was automatically generated when creating the release?
There was a problem hiding this comment.
I thought you still needed these since they have them in Terra, but maybe @mtreinish knows?
There was a problem hiding this comment.
Yes this is still needed. The changelog is automated now, but release documentation still needs to be written. The previous changelog was serving double duty as release documentation (frankly quite poorly). See the contributing docs on this: https://github.com/Qiskit/qiskit-aer/blob/master/CONTRIBUTING.md#release-notes (the changelog section above it mentions the changelog autogeneration)
Summary
Fixes issue where memory requirements of simulation were not being checked on the QasmSimulator when using a non-automatic simulation method.
Closes #755
Details and comments