Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rotation gates to noise model and simulators #914

Merged
merged 15 commits into from
Sep 24, 2020
Merged

Add support for rotation gates to noise model and simulators #914

merged 15 commits into from
Sep 24, 2020

Conversation

chriseclectic
Copy link
Member

@chriseclectic chriseclectic commented Aug 31, 2020 •
edited
Loading

Summary

Adds support for rotation gates to simulators.

Details and comments

  • Adds support for r, rx, ry, rz, rxx, ryy, rzz, rzx to statevector, unitary, density_matrix, superop simulation methods
  • Also adds support for multicontrolled mcr, mcrx, mcry, mcrz gates to the unitary and statevector simulation methods.

TODO

  • Needs tests

Followup:

  • add rotation gate support to MPS simulator
  • Add support for SXGate, and PhaseGate, CPhaseGate, DelayGate

@chriseclectic chriseclectic added the on hold Can not fix yet label Aug 31, 2020
@chriseclectic chriseclectic added this to the Aer 0.7 milestone Aug 31, 2020
@chriseclectic chriseclectic requested a review from atilag as a code owner August 31, 2020 18:06
@ajavadia ajavadia mentioned this pull request Sep 1, 2020
Closed
vvilpas
vvilpas reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@vvilpas vvilpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems fine. Most of my comments are regarding formatting. I'm not sure, looks like they are not intended. My guess is that some auto formatting tool has kicked in, changing many things. I've pointed out some of them that seem odd to me.
I'll review the tests when they are added.

qiskit/providers/aer/backends/qasm_simulator.py Outdated Show resolved Hide resolved
qiskit/providers/aer/backends/unitary_simulator.py Outdated Show resolved Hide resolved
qiskit/providers/aer/backends/unitary_simulator.py Show resolved Hide resolved
src/framework/linalg/matrix_utils/smatrix_defs.hpp Show resolved Hide resolved
src/noise/noise_model.hpp Show resolved Hide resolved
src/simulators/superoperator/superoperator_state.hpp Outdated Show resolved Hide resolved
src/simulators/superoperator/superoperator_state.hpp Outdated Show resolved Hide resolved
src/simulators/superoperator/superoperator_state.hpp Outdated Show resolved Hide resolved
src/simulators/unitary/unitary_state.hpp Outdated Show resolved Hide resolved
src/simulators/unitary/unitary_state.hpp Outdated Show resolved Hide resolved
@chriseclectic chriseclectic added Changelog: New Feature Include in the Added section of the changelog and removed on hold Can not fix yet labels Sep 15, 2020
@chriseclectic chriseclectic changed the title [WIP] Add support for rotation gates to noise model and simulators Add support for rotation gates to noise model and simulators Sep 23, 2020
@vvilpas vvilpas merged commit 7d0ecf4 into Qiskit:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvilpas vvilpas vvilpas approved these changes

@atilag atilag Awaiting requested review from atilag

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
Aer 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@chriseclectic @vvilpas