fix a bug in thread management tests #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
the
Changelog: Bugfix
chriseclectic
requested changes
Sep 2, 2020
hhorii
force-pushed
the
fix_thraed_mgmt_test
branch
from
815fdac to
8ac9fb0
Compare
vvilpas
reviewed
Sep 9, 2020
hhorii
force-pushed
the
fix_thraed_mgmt_test
branch
from
5834b09 to
34dda9a
Compare
chriseclectic
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change a way to get a number of maximum threads in
QasmThreadManagementTestsDetails and comments
In some environment,
multiprocessing.cpu_count()does not return a number of maximum OMP threads correctly.Especially if
OMP_NUM_THREADSis different from an actual number of hardware threads, tests are failed.This PR changes a way to get a number of maximum OMP threads by running dummy simulation.
I hope that this PR resolves issues in #892.