Make controller_wrapper functions functors #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
vvilpas
reviewed
Sep 22, 2020
chriseclectic
added
the
Changelog: Bugfix
mtreinish
reviewed
Sep 22, 2020
There was a problem hiding this comment.
Can you add a test case for the pickle/deepcopy of the backend classes? Something like: https://github.com/Qiskit/retworkx/blob/master/tests/test_deepcopy.py (which is what I added when I had to fix a deepcopy/pickle issue in Qiskit/rustworkx#15)
I didn't know copy.deepcopy used the functionality I think we're going for .. but it kind of makes sense, cool. I might've gone a bit overboard but lmk what you think. |
chriseclectic
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adjusts the controller_execute functions to be functors rather than free-functions. This allows pickling of these objects - specifically it allows them to be used in multiprocessing.map(...) calls.
Details and comments
See pybind/pybind11#1261