Move AVX2 logic into Transformer class and enable SIMD on Unitary, DensityMatrix, SuperOp #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
Changelog: New Feature
chriseclectic
force-pushed
the
refactor/qubitvector-avx2
branch
3 times, most recently
from
537556f to
03f9465
Compare
chriseclectic
changed the title
vvilpas
reviewed
Sep 30, 2020
This moves AVX2 logic into the class where it is used and removes needing to handle checking in the controller class. This also enables AVX2 automatically for unitary, density matrix, and superoperator simualtors since they inhert the applied matrix function from Qubitvector.
This adds back in similar structure to the previous QubitvectorAvx2 but in a separate class so it doesn't need to instantiated in other parts of the simulator code outside qubitvector.
…y_diagonal_matrix Updates indexes to only use omp parallel if threads > 1, not > 0.
It seems we were applying the special case for 1 qubit for some cases where we have more than 1 qubit.
chriseclectic
force-pushed
the
refactor/qubitvector-avx2
branch
from
c8e8615 to
d007c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves AVX2 logic into the class where it is used and removes needing to handle checking in the controller class. This also enables AVX2 automatically for unitary, density matrix, and superoperator simulators since they inherit the applied matrix function from Qubitvector.
Details and comments
apply_matrixinto the base QubitVector class.apply_matrixfunction.