-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for a configurable default branch #9
Conversation
There has been a recent push to rename the default branch for git repositories to be something more inclusive than 'master'. Qiskit would like to make this transition and rename the default branch to 'main'. However, qiskit-bot has been blocking this transition because it unconditionally was using 'master' for generating pull requests, updating local checkouts, etc. To address this and enable us to transition away from using 'master' for our default branch this commit adds a new optional per repo configuration option 'default_branch' which is used to set the default branch for a repository. If not set it defaults to using master so there is no breaking change for the deployed bot and we can update the configuration as we rename the branches. Similarly for the metapackage repository a new optional configuration option, 'meta_repo_default_branch', is added that behaves the same way but for the meta_repo.
With the pending support being added to qiskit-bot in Qiskit/qiskit-bot#9 we're able to rename the default branch for the repository to 'main'. However, when we do that several things will need to be updated, most importantly the CI trigger was hardcoded to the previous default branch 'master. This commit fixes these references and should be merged after we rename the branch to re-enable CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. One could also argue for eventually nhaving the default value of default_branch
be main
instead, since already github has moved to main for new repos and git itself plans to make that change at some point soon
Yeah I think that's fair to do once all of qiskit has migrated to use |
With the pending support being added to qiskit-bot in Qiskit/qiskit-bot#9 we're able to rename the default branch for the repository to 'main'. However, when we do that several things will need to be updated, most importantly the CI trigger was hardcoded to the previous default branch 'master. This commit fixes these references and should be merged after we rename the branch to re-enable CI.
With the recent support added to qiskit-bot for configurable default branches in Qiskit/qiskit-bot#9 we're able to rename the default branch for the repository to 'main'. However, when we do that several things will need to be updated, most importantly the CI trigger was hardcoded to the previous default branch 'master. This commit fixes these references and should be merged after we rename the branch to re-enable CI.
With the recent support added to qiskit-bot for configurable default branches in Qiskit/qiskit-bot#9 we're able to rename the default branch for the repository to 'main'. However, when we do that several things will need to be updated, most importantly the CI trigger was hardcoded to the previous default branch 'master. This commit fixes these references and should be merged after we rename the branch to re-enable CI.
With the recent support added to qiskit-bot for configurable default branches in Qiskit/qiskit-bot#9 we're able to rename the default branch for the repository to 'main'. However, when we do that several things will need to be updated, most importantly the CI trigger was hardcoded to the previous default branch 'master. This commit fixes these references and should be merged after we rename the branch to re-enable CI.
There has been a recent push to rename the default branch for git
repositories to be something more inclusive than 'master'. Qiskit would
like to make this transition and rename the default branch to 'main'.
However, qiskit-bot has been blocking this transition because it
unconditionally was using 'master' for generating pull requests,
updating local checkouts, etc. To address this and enable us to
transition away from using 'master' for our default branch this commit
adds a new optional per repo configuration option 'default_branch' which
is used to set the default branch for a repository. If not set it
defaults to using master so there is no breaking change for the deployed
bot and we can update the configuration as we rename the branches.
Similarly for the metapackage repository a new optional configuration
option, 'meta_repo_default_branch', is added that behaves the same way
but for the meta_repo.