Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Raise error when use_measure_esp not supported #618

Merged
merged 7 commits into from
May 15, 2023

Conversation

merav-aharoni
Copy link
Collaborator

Summary

Raise error when parameter use_measure_esp=True in IBMBackend.run(), but backend has measure_esp_enabled==False.

Details and comments

See issue #491 .

  • I am not sure what the status is with this feature. I saw several relevant tests, so enabled one of them.
  • I checked all the backends with
    backends = provider.backends(measure_esp_enabled=True)
    and got [], so I guess no backends support this feature. Is this something planned for the future? Do we want this PR and should I enable the remaining tests?

@coveralls
Copy link

coveralls commented May 9, 2023

Pull Request Test Coverage Report for Build 4984532224

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-4.0e**-05%**) to 50.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_backend.py 1 2 50.0%
Totals Coverage Status
Change from base Build 4984333559: -4.0e-05%
Covered Lines: 3025
Relevant Lines: 6035

💛 - Coveralls

@merav-aharoni merav-aharoni marked this pull request as ready for review May 9, 2023 18:30
@merav-aharoni merav-aharoni requested a review from kt474 May 14, 2023 06:03
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! To answer your question, there are currently backends that have measure_esp_enabled set to True so the test that you enabled will now pass.

@kt474 kt474 merged commit 08b4a6b into Qiskit:main May 15, 2023
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label May 15, 2023
@merav-aharoni merav-aharoni deleted the use_measure_esp branch May 18, 2023 18:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants