Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix circuit metadata serialization bug #648

Merged
merged 5 commits into from
Jun 1, 2023
Merged

Fix circuit metadata serialization bug #648

merged 5 commits into from
Jun 1, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented May 31, 2023

Summary

Originally reported in the pec-runtime repo - circuit metadata was not being serialized correctly

RuntimeEncoder isn't passed in as the metadata_serializer param here so write_circuit is using the default JSON encoder

fixes #582

Details and comments

@coveralls
Copy link

coveralls commented May 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5136746902

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 51.846%
Totals Coverage Status
Change from base Build 5126129439: 1.6%
Covered Lines: 3132
Relevant Lines: 6041
💛 - Coveralls

@kt474 kt474 requested a review from merav-aharoni May 31, 2023 19:09
@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label May 31, 2023
merav-aharoni
merav-aharoni approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coruscating coruscating mentioned this pull request Jun 1, 2023
Merged
7 tasks
@kt474 kt474 merged commit e2e4463 into Qiskit:main Jun 1, 2023
@kt474 kt474 deleted the serialization-bug branch June 1, 2023 17:15
@kt474 kt474 mentioned this pull request Jul 13, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@merav-aharoni merav-aharoni merav-aharoni approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for more types in qpy serialization
3 participants
@kt474 @coveralls @merav-aharoni