Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Reset backend options to default in get_backend #705

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

merav-aharoni
Copy link
Collaborator

@merav-aharoni merav-aharoni commented Aug 13, 2023

Summary

Reset backend.options to default in IBMProvider.get_backend().

Details and comments

See #489 - Please consider if you agree with my approach.
If we all agree, this should also be fixed in qiskit_ibm_runtime.

@coveralls
Copy link

coveralls commented Aug 13, 2023

Pull Request Test Coverage Report for Build 5847725856

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 51.089%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_provider.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_provider/ibm_provider.py 1 52.67%
Totals Coverage Status
Change from base Build 5835664226: -0.008%
Covered Lines: 3307
Relevant Lines: 6473

💛 - Coveralls

@merav-aharoni merav-aharoni marked this pull request as ready for review August 13, 2023 14:10
@merav-aharoni
Copy link
Collaborator Author

merav-aharoni commented Aug 14, 2023

This is also related to #486. However there, it is not the options that need to be reset, but the entire config. Do we want to do this?

Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the main branch I ran the following code snippet - aren't the backend options already reset to default? Or am I missing something

Screenshot 2023-08-14 at 12 33 24 PM

@merav-aharoni
Copy link
Collaborator Author

On the main branch I ran the following code snippet - aren't the backend options already reset to default? Or am I missing something

Screenshot 2023-08-14 at 12 33 24 PM

This is very strange, because I get

4000
200
200

For the same code. Can you double check you are indeed running on the main branch?

@kt474
Copy link
Member

kt474 commented Aug 20, 2023

For the same code. Can you double check you are indeed running on the main branch?

Running in a custom anaconda env I now get the same results as you - not sure what causes this discrepancy but change LGTM

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Aug 21, 2023
@kt474 kt474 merged commit d724b5d into Qiskit:main Aug 22, 2023
18 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants