Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix Parameter uuid on deserialization #771

Merged
merged 2 commits into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions qiskit_ibm_provider/qpy/binary_io/value.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,7 @@ def _read_parameter(file_obj): # type: ignore[no-untyped-def]
)
param_uuid = uuid.UUID(bytes=data.uuid)
name = file_obj.read(data.name_size).decode(common.ENCODE)
param = Parameter.__new__(Parameter, name, uuid=param_uuid)
param.__init__(name) # pylint: disable=unnecessary-dunder-call
param = Parameter(name, uuid=param_uuid)
return param


Expand Down
15 changes: 15 additions & 0 deletions test/unit/test_serialization.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,18 @@ def test_noise_model(self):
self.assertIsInstance(decoded, NoiseModel)
self.assertEqual(noise_model.noise_qubits, decoded.noise_qubits)
self.assertEqual(noise_model.noise_instructions, decoded.noise_instructions)

def test_param(self):
"""Test encoding and decoding a parameter."""
param = Parameter("a")
encoded = json.dumps(param, cls=RuntimeEncoder)
self.assertIsInstance(encoded, str)
with warnings.catch_warnings():
warnings.filterwarnings(
"ignore",
category=DeprecationWarning,
)
decoded = json.loads(encoded, cls=RuntimeDecoder)
self.assertIsInstance(decoded, Parameter)
self.assertEqual(param.name, decoded.name)
self.assertEqual(param._uuid, decoded._uuid)
Loading