-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to indicate they are done submitting jobs to a session #1123
Conversation
Pull Request Test Coverage Report for Build 6451540490
💛 - Coveralls |
|
||
.. warning:: | ||
Close a session only after all session jobs **complete**, rather than immediately after they have all been submitted. Session jobs that are not completed will fail. | ||
When a session that is not accepting jobs has run out of jobs to run, it is immediately closed. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beckykd should docs updates be in a separate PR? I'll probably need help with the wording on a lot of these - it will also be a bit tricky since once this is released, older versions of qiskit-ibm-runtime
will behave differently
closing this and reopening on a fresh branch since this no longer depends on a different PR |
Summary
WIP: PR is branched from #1119, so ideally that is merged firstsession.close()
to indicate one is done submitting to the session by usingaccepting_jobs = false
.session.cancel()
terminates all jobs inside a session (this is the old close method, still calls/close
).session.close()
is called upon exiting session in context managerDetails and comments
Fixes #1008