Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use backend service in session if known #601

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Use backend service in session if known #601

merged 2 commits into from
Nov 2, 2022

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Nov 1, 2022

Summary

If I pass an IBMBackend instance to Session constructor, the service used to initialize the backend instance should be used for the session, if no other service parameter is passed.

Details and comments

Fixes #

@coveralls
Copy link

coveralls commented Nov 1, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3373370439

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 64.018%
Totals Coverage Status
Change from base Build 3347325922: 0.01%
Covered Lines: 3359
Relevant Lines: 5247
💛 - Coveralls

@jyu00 jyu00 requested a review from kt474 November 2, 2022 13:27
kt474
kt474 approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit 3cbbeaa into Qiskit:main Nov 2, 2022
@jyu00 jyu00 added the Changelog: Bugfix Include in the Fixed section of the changelog label Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyu00 @coveralls @kt474