Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalProvider #1029

Merged
merged 2 commits into from
Oct 31, 2023
Merged

LocalProvider #1029

merged 2 commits into from
Oct 31, 2023

Conversation

akihikokuroda
Copy link
Collaborator

Summary

Add LocalProvider

Details and comments

@akihikokuroda akihikokuroda marked this pull request as draft October 16, 2023 21:10
@akihikokuroda
Copy link
Collaborator Author

@IceKhan13 Am I on the right track?

@IceKhan13
Copy link
Member

IceKhan13 commented Oct 17, 2023 •
edited
Loading

Direction is looking good to me :)
I also was thinking about this in a same way.

We will need to test how good it works though :)

@akihikokuroda
Copy link
Collaborator Author

@IceKhan13 Thanks!

@IceKhan13 IceKhan13 linked an issue Oct 18, 2023 that may be closed by this pull request
Local development / test suite #1032
Closed
@akihikokuroda akihikokuroda marked this pull request as ready for review October 27, 2023 23:58
@akihikokuroda akihikokuroda force-pushed the localprovider branch 2 times, most recently from 8119f58 to ab5c16b Compare October 28, 2023 13:44
@akihikokuroda
LocalProvider
ae985c8 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
psschwei
psschwei reviewed Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error when trying to run using local provider:

image

@akihikokuroda
Copy link
Collaborator Author

@psschwei serverless.upload(pattern) need to be executed before run. Would you try?

@psschwei
Copy link
Collaborator

Good catch... (I followed the steps in the issue, which was written before upload was a thing...)

@psschwei
Copy link
Collaborator

It worked, although I did get a warning when getting the results:

image

@IceKhan13
Copy link
Member

I think we can raise NotImplementedException with message that LocalProvider does not support uploaded programs. And ask user to use run(Program("...", entrypoint="bla.py", working_dir="./asdasd"))

@IceKhan13
Copy link
Member

ah, I see how you did it :) feel free to ignore above message

@akihikokuroda
Copy link
Collaborator Author

akihikokuroda commented Oct 30, 2023 •
edited
Loading

It supports both. For the new pattern, 'load' must be called before 'run' . It's the same way as serverless provider.

@akihikokuroda
Copy link
Collaborator Author

I'll look into the warning. Thanks!

@IceKhan13 IceKhan13 added this to the 0.7 milestone Oct 30, 2023
@psschwei psschwei mentioned this pull request Oct 30, 2023
Merged
@akihikokuroda
Copy link
Collaborator Author

@psschwei The waring should have gone now.

@IceKhan13 IceKhan13 merged commit ee7304f into Qiskit:main Oct 31, 2023
6 checks passed
@akihikokuroda akihikokuroda deleted the localprovider branch October 31, 2023 13:47
caleb-johnson pushed a commit to caleb-johnson/quantum-serverless that referenced this pull request Nov 1, 2023
@akihikokuroda @caleb-johnson
LocalProvider (Qiskit#1029)
f15a4b3
caleb-johnson added a commit that referenced this pull request Nov 1, 2023
@caleb-johnson
Update __init__.py
c1a3c53 
#1029 accidentally removed `Program` from being importable at this level, when it is still in its deprecation period.

This PR re-adds that module as importable from the `core` package until its deprecation period is over.
@caleb-johnson caleb-johnson mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceKhan13 IceKhan13 IceKhan13 approved these changes

@psschwei psschwei psschwei approved these changes

@Tansito Tansito Awaiting requested review from Tansito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

Local development / test suite
3 participants
@akihikokuroda @IceKhan13 @psschwei