Issue 1036 | Add program upload #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceKhan13
requested review from
akihikokuroda,
psschwei and
Tansito
and removed request for
akihikokuroda
psschwei
reviewed
Oct 20, 2023
| def files(self) -> List[str]: | ||
| """Returns list of available files produced by programs to download.""" | ||
| raise NotImplementedError | ||
|
|
||
| def download(self, file: str, download_location: str): | ||
| def file_download(self, file: str, download_location: str): |
There was a problem hiding this comment.
I don't think anyone has implemented their own provider, so this probably is more academic than anything else, but for sake of completeness: should we deprecate the download function?
There was a problem hiding this comment.
It is "experimental" feature :)
but anyway it is a good practice. Deprecated download in 6e690da
There was a problem hiding this comment.
do we need to deprecate the other functions too? (*hides*)
There was a problem hiding this comment.
not, upload though. That is why I though it is a strange thing to deprecate half and not the other
psschwei
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds program upload
Details and comments
Following
build -> deploy -> runflowOld interface where we provide full
Programdefinition on each run still works.Example notebook: https://github.com/Qiskit-Extensions/quantum-serverless/blob/issue-1036/upload-programs/docs/getting_started/experimental/upload_program.ipynb
This is minimal implementation. Additional things that need to be added in following PRs:
Closes #1036