Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program upload refactorization #1112

Merged
merged 17 commits into from
Nov 22, 2023
Merged

Program upload refactorization #1112

merged 17 commits into from
Nov 22, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Nov 20, 2023

Summary

The idea of this PR is to propose a structure to start simplifying our views. We remove logic from them to services to improve readability and separation of concerns. In this case the implementation is the next one:

  • ProgramService creation where we are going to add the business logic around Programs
  • Versioning for ProgramService, this way we complement the serializers and the views
  • Included a test for the new service and its method
  • Included a set of custom exceptions to help us to manage tricky situations

Now the view it's only responsible to manage information with Requests & Responses delegating the rest of the logic into the services.

@Tansito Tansito changed the title 🏗️ Program upload refactorization Program upload refactorization Nov 21, 2023
@Tansito Tansito marked this pull request as ready for review November 21, 2023 00:02
Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! ✨

@Tansito Tansito merged commit f81a2f8 into main Nov 22, 2023
6 checks passed
@Tansito Tansito deleted the upload-refactorization branch November 22, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants