Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pick up some client config from env var #1146

Merged
merged 1 commit into from
Dec 12, 2023
Merged

pick up some client config from env var #1146

merged 1 commit into from
Dec 12, 2023

Conversation

akihikokuroda
Copy link
Collaborator

Summary

Fix #1064

Details and comments

These config values can be overridden by setting the following environment variables in the client environment.

REQUESTS_TIMEOUT_OVERRIDE
MAX_ARTIFACT_FILE_SIZE_MB_OVERRIDE
IBM_SERVERLESS_HOST_URL_OVERRIDE

@akihikokuroda
pick up some client config from env var
637f5d3 
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
IceKhan13
IceKhan13 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akihikokuroda akihikokuroda merged commit b170dbd into Qiskit:main Dec 12, 2023
20 checks passed
@akihikokuroda akihikokuroda deleted the clientconfig branch December 12, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceKhan13 IceKhan13 IceKhan13 approved these changes

@Tansito Tansito Tansito approved these changes

@psschwei psschwei Awaiting requested review from psschwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config values should be configurable without having to reinstall
3 participants
@akihikokuroda @IceKhan13 @Tansito