Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarifying message for failed jobs with no logs #1173

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

david-alber
Copy link
Contributor

Summary

closes #852

  • adding functionality (check_logs) to enhance the logs of a failed job with no logs with an error message that acknowledges the failure.
  • adding respective unit tests and testing the expected behavior when the job status is updated.

Details and comments

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@akihikokuroda
Copy link
Collaborator

@david-alber Thanks for your contribution. It looks good to me!

Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @david-alber !

@IceKhan13 IceKhan13 merged commit b48b886 into Qiskit:main Jan 19, 2024
20 checks passed
@david-alber
Copy link
Contributor Author

yey Thanks @IceKhan13 @akihikokuroda This was fun!!!
Looking forward to the next one

@david-alber david-alber deleted the fixissue/852 branch January 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway: when job failed and logs are empty, add clarifying message.
4 participants