add runtimejob handling additional apis #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
IceKhan13
reviewed
Jan 29, 2024
| job = self.get_object() | ||
| runtimejob = RuntimeJob( | ||
| job=job, | ||
| runtime_job=request.data.get("runtime_job"), |
There was a problem hiding this comment.
Should we check that runtime_job got passed in request somehow to display user friendly error?
Something like
if not request.data.get("runtime_job"):
return Response({"message": "Got empty `runtime_job` field. Please, specify `runtime_job`."}, code / status=400)
IceKhan13
reviewed
Jan 29, 2024
gateway/api/views.py
Outdated
| ctx = TraceContextTextMapPropagator().extract(carrier=request.headers) | ||
| with tracer.start_as_current_span("gateway.job.stop", context=ctx): | ||
| job = self.get_object() | ||
| runtimejobs = RuntimeJob.objects.all().filter(job=job) |
There was a problem hiding this comment.
Suggested change
| runtimejobs = RuntimeJob.objects.all().filter(job=job) | |
| runtimejobs = RuntimeJob.objects.filter(job=job) |
|
@IceKhan13 Thanks for review. I updated both places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to: #1163
Details and comments
Adding runtime job to the job:
list the runtime jobs created in the job: