Remove default login view #1215
Conversation
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
|
Hey @akihikokuroda I just saw your PR. The only requirement is remove the end-points in the view, we continue using custom logic through the library to manage access in the rest of the end-points with iqp. |
|
@Tansito I can simply take out the urls from the |
|
Yes! I think it has sense. But I think there is no a lot of things to remove there because we are using a custom rule for IQP using most of the modules for the authentication (If I remember correctly). |
|
But yeah, definitely it will deserve the effort |
|
Regardless my comments @akihikokuroda, removing |
|
@Tansito I tried to takeout some modules in the requirements.txt but some part of them are still used. So I couldn't take any out. |
|
Oh, I see. I will take a look anyway monday into this taking advantage that I need to test too the |
There was a problem hiding this comment.
mock_token continues working, changes LGTM, thank you @akihikokuroda 👍
(maybe we should use the mock token awesome_token for authenticate but it's another conversation)
|
@Tansito Thanks for checking! |
* remove default login view Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
* adding api documentation (swagger & redoc) to gateway * allow unauthenticated users to read RuntimeJobViewSet * allow swagger docu if user is not yet set * only show api/v1/ patterns, add token authorization, rm django login * drop jupyter from main helm readme (#1208) Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * CatalogEntry API (#1204) * add ModelView API for CatalogEntry * additional apis for catalogentry --------- Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> * Repository removal (#1207) * Removed main components from repository project * Updated chart lock * Remove repository references from the client * add catalog status (#1211) Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> * Use LocalProvider for test (#1212) * use LocalProvider for notebook test Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> * Documentation update (#1214) * Update contribution guidelines * Update contributing doc with supported python versions * Remove Python 3.7 badge from README files * Upgrade min python version in setup.py * Test notebooks against k8s qs deployment (#1216) * test notebooks against k8s qs deployment Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * update notebook location Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * use action for kind creation Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * test all notebooks Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * drop sleep Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> This was redundant, as the python setup in the next few steps takes waaaay longer than 60s --------- Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> * Take out unnecessary Job.save() (#1217) * take out unnecessary Job.save() Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> * Update Helm release kuberay-operator to v1 (#1121) * Update Helm release kuberay-operator to v1 * Update api version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David <9059044+Tansito@users.noreply.github.com> * Fix link for Qiskit deprecation policy (#1218) * Remove default login view (#1215) * remove default login view Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> * adding api documentation (swagger & redoc) to gateway --------- Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com> Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com> Co-authored-by: Paul Schweigert <paul@paulschweigert.com> Co-authored-by: Akihiko (Aki) Kuroda <16141898+akihikokuroda@users.noreply.github.com> Co-authored-by: David <9059044+Tansito@users.noreply.github.com> Co-authored-by: Karla Spuldaro <karla.spuldaro@ibm.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Summary
fix #1209
Details and comments