Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker lint action #1221

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix docker lint action #1221

merged 3 commits into from
Feb 13, 2024

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Feb 12, 2024

Summary

Fix #1220

Details and comments

Pinned vim version to fix the error in the Docker lint action

@psschwei
Copy link
Collaborator

For whatever reason, the Kubernetes test appears to be stuck trying to run jobs...

image

Not sure what exactly is going on there...

@Tansito
Copy link
Member Author

Tansito commented Feb 12, 2024

Yep, it started to happen in all the pull_requests today 🤔

Let me know if you need help with it, @psschwei

@psschwei
Copy link
Collaborator

Maybe we should add --full-trace to the pytest call in the k8s test to see if that shows us any additional info?

@Tansito
Copy link
Member Author

Tansito commented Feb 12, 2024

I don't see any problem I suppose 🤷‍♂️

@psschwei
Copy link
Collaborator

Trying in #1222

@Tansito
Copy link
Member Author

Tansito commented Feb 12, 2024

At least linter errors disappeared 😂

@psschwei
Copy link
Collaborator

psschwei commented Feb 12, 2024

We broke something in #1121
tl/dr: the API version in the data (ray.io/v1) does not match the expected API version (ray.io/v1alpha1)

Full logs:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 55, in inner
    resp = func(self, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 270, in request
    api_response = self.client.call_api(
  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 348, in call_api
    return self.__call_api(resource_path, method,
  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 180, in __call_api
    response_data = self.request(
  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 391, in request
    return self.rest_client.POST(url,
  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/rest.py", line 279, in POST
    return self.request("POST", url,
  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/rest.py", line 238, in request
    raise ApiException(http_resp=r)
kubernetes.client.exceptions.ApiException: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Audit-Id': '66ed4609-46aa-49ce-b2da-ded45a9f6080', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Warning': '299 - "unknown field \\"spec\\""', 'X-Kubernetes-Pf-Flowschema-Uid': '1af9dae2-d851-4714-915e-8b17a1e786f4', 'X-Kubernetes-Pf-Prioritylevel-Uid': '535ac6ae-8ea1-41f2-a4fe-4e34f58b62c4', 'Date': 'Mon, 12 Feb 2024 22:04:03 GMT', 'Content-Length': '212'})
HTTP response body: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"the API version in the data (ray.io/v1) does not match the expected API version (ray.io/v1alpha1)","reason":"BadRequest","code":400}\n'


During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/src/app/manage.py", line 47, in <module>
    main()
  File "/usr/src/app/manage.py", line 43, in main
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 436, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 412, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 458, in execute
    output = self.handle(*args, **options)
  File "/usr/src/app/api/management/commands/schedule_queued_jobs.py", line 71, in handle
    job = execute_job(job)
  File "/usr/src/app/api/schedule.py", line 72, in execute_job
    compute_resource = create_ray_cluster(
  File "/usr/src/app/api/ray.py", line 233, in create_ray_cluster
    response = raycluster_client.create(body=cluster_data, namespace=namespace)
  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 119, in create
    return self.request('post', path, body=body, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 57, in inner
    raise api_exception(e)
kubernetes.dynamic.exceptions.BadRequestError: 400
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Audit-Id': '66ed4609-46aa-49ce-b2da-ded45a9f6080', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Warning': '299 - "unknown field \\"spec\\""', 'X-Kubernetes-Pf-Flowschema-Uid': '1af9dae2-d851-4714-915e-8b17a1e786f4', 'X-Kubernetes-Pf-Prioritylevel-Uid': '535ac6ae-8ea1-41f2-a4fe-4e34f58b62c4', 'Date': 'Mon, 12 Feb 2024 22:04:03 GMT', 'Content-Length': '212'})
HTTP response body: b'{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"the API version in the data (ray.io/v1) does not match the expected API version (ray.io/v1alpha1)","reason":"BadRequest","code":400}\n'
Original traceback: 
  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 55, in inner
    resp = func(self, *args, **kwargs)

  File "/usr/local/lib/python3.9/site-packages/kubernetes/dynamic/client.py", line 270, in request
    api_response = self.client.call_api(

  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 348, in call_api
    return self.__call_api(resource_path, method,

  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 180, in __call_api
    response_data = self.request(

  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/api_client.py", line 391, in request
    return self.rest_client.POST(url,

  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/rest.py", line 279, in POST
    return self.request("POST", url,

  File "/usr/local/lib/python3.9/site-packages/kubernetes/client/rest.py", line 238, in request
    raise ApiException(http_resp=r)

@akihikokuroda
Copy link
Collaborator

@psschwei @Tansito I'll take a look.

@Tansito
Copy link
Member Author

Tansito commented Feb 13, 2024

Oh wow, good catch @akihikokuroda ! (and really good test @psschwei 😄) I'm going just to use this pull request to fix it

@psschwei
Copy link
Collaborator

the linter strikes again 😆

@Tansito
Copy link
Member Author

Tansito commented Feb 13, 2024

Yeah, but they are other ones haha. I suppose that it's due to the last change, I will take a look in a couple of minutes 👍

@Tansito
Copy link
Member Author

Tansito commented Feb 13, 2024

Checks passed! 🎉

@Tansito Tansito merged commit af8d62a into main Feb 13, 2024
15 checks passed
@Tansito Tansito deleted the docker-lint-error branch February 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix docker lint action
3 participants