Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating docs notebook dependencies + use latest fakebackend #1227

Merged
merged 6 commits into from
Feb 21, 2024
Merged

updating docs notebook dependencies + use latest fakebackend #1227

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a687035
updating docs notebook dependencies + use latest fakebackend
david-alber Feb 19, 2024
4a55ef3
rm qiskit-ibm-provier from client dependencies + GenericBackendV2 bugfix
david-alber Feb 19, 2024
d0b144e
exchange qiskit-ibm-provider with runtime
david-alber Feb 19, 2024
3bc7122
using latest qiskit-ibm-provider
david-alber Feb 19, 2024
b061da8
equal dependencies in requirements and k8s-deployment
david-alber Feb 20, 2024
d21d14f
updating docs custom dependencies to qiskit 1.0.0 compatible
david-alber Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/kubernetes-deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ jobs:
cd client
pip install . --no-cache-dir
pip install --no-cache-dir \
ipywidgets==8.1.0 \
circuit-knitting-toolbox==0.2.0 \
ipywidgets==8.1.1 \
circuit-knitting-toolbox>=0.6.0 \
matplotlib==3.7.1 \
pyscf==2.2.1 \
scipy==1.10 \
qiskit-ibmq-provider==0.20.2 \
qiskit-aer==0.12.0 \
qiskit-ibm-provider>=0.9.0 \
qiskit-aer>=0.13.3 \
certifi==2023.7.22
pip install nbmake pytest
- name: Run notebooks
Expand Down
6 changes: 4 additions & 2 deletions client/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@ ray[default,data]>=2.9.1, <3
requests>=2.31.0
importlib-metadata>=5.2.0
qiskit>=0.45.2
qiskit-ibm-runtime>=0.18.0
qiskit-ibm-provider>=0.8.0
qiskit-ibm-runtime>=0.19.1
qiskit-ibm-provider>=0.9.0
# Forbid qiskit-terra from individual install with impossible version constraint.
# qiskit-terra>=1
# TODO: make sure ray node and notebook node have the same version of cloudpickle
cloudpickle==2.2.1
tqdm>=4.65.0
Expand Down
10 changes: 5 additions & 5 deletions client/tests/library/test_transpiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

from qiskit import QuantumCircuit
from qiskit.circuit.random import random_circuit
from qiskit.providers.fake_provider import FakeAlmadenV2, FakeBrooklynV2
from qiskit.providers.fake_provider import GenericBackendV2

from quantum_serverless import QuantumServerless
from quantum_serverless.exception import QuantumServerlessException
Expand All @@ -31,8 +31,8 @@ def test_transpile(self):
circuit1 = random_circuit(5, 3)
circuit2 = random_circuit(5, 3)

backend1 = FakeAlmadenV2()
backend2 = FakeBrooklynV2()
backend1 = GenericBackendV2(num_qubits=5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it matters for these tests, but I found this replacement list for deprecated fake providers, FakeAlmadenV2 is now Fake20QV1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karlaspuldaro,
I decided to use the GenericBackendV2 because it seems to be the only qiskit.providers.fake_provider that is not a legacy interface.
Do you see an advantage of using Fake20QV1 over GenericBackendV2?
I think either one would be fine 😃.

backend2 = GenericBackendV2(num_qubits=5)

with QuantumServerless().context():
transpiled_circuits = parallel_transpile(
Expand All @@ -48,8 +48,8 @@ def test_transpile_fail(self):
"""Test failing cases for parallel transpile."""
circuit1 = random_circuit(5, 3)

backend1 = FakeAlmadenV2()
backend2 = FakeBrooklynV2()
backend1 = GenericBackendV2(num_qubits=5)
backend2 = GenericBackendV2(num_qubits=5)

with QuantumServerless().context():
# inconsistent number of circuits and backends
Expand Down
Loading