Rename function.get_jobs to function.jobs and make it return Job objects #1480
Conversation
|
By importing the |
There was a problem hiding this comment.
It is ok for now. Reason why it is happening is function and job files are located in the same level in different files, therefore python is trying to initialize first file with reference to another file without being initialized. And you have circular references (one is referring to another in a cycle).
Later on solution will be to move Job class to higher level and refer job from function and job_client files.
| @@ -118,7 +118,7 @@ def run(self, **kwargs): | |||
| config=config, | |||
| ) | |||
|
|
|||
| def get_jobs(self): | |||
There was a problem hiding this comment.
Something that we probably should do before merge is to add a deprecation warning here instead to remove it. Just to avoid a breaking change in the catalog until we release a new version.
There was a problem hiding this comment.
I can create an additional PR solving this.
Summary
fix #1479
fix #1463
Details and comments