Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add catalog/by_title entry-point #1498

Merged
merged 11 commits into from
Sep 25, 2024
Merged

Conversation

akihikokuroda
Copy link
Collaborator

Summary

add catalog/by_title entry-point

Details and comments

gateway/api/views.py Outdated Show resolved Hide resolved
@psschwei
Copy link
Collaborator

Too many positional arguments (6/5)

Should we bump the default up a bit? seems like there's a few that are getting caught with 6/5, so maybe upping the limit is the right thing to do here?

@akihikokuroda
Copy link
Collaborator Author

@psschwei The error didn't happen before. I'm not sure if this check was not enabled or the default is lowered. @Tansito is trying to find what happened and making the right change.

@Tansito
Copy link
Member

Tansito commented Sep 22, 2024

@akihikokuroda it seems we found the culprit:

How the problem is not in our side feel free to restore cf6e489 and I will open an issue Monday to monitor it and planify the refactorization if we consider it needed.

gateway/api/views.py Show resolved Hide resolved
gateway/api/views.py Outdated Show resolved Hide resolved
gateway/api/views.py Outdated Show resolved Hide resolved
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As last thing Aki, remember to add the end-point to the V1 interfaces like in this example:

https://github.com/Qiskit/qiskit-serverless/blob/main/gateway/api/v1/views.py#L116

@Tansito Tansito self-requested a review September 25, 2024 17:33
Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Aki! 🙏

@akihikokuroda akihikokuroda merged commit 15fcb4e into Qiskit:main Sep 25, 2024
10 checks passed
@akihikokuroda akihikokuroda deleted the bytitle branch September 25, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants