fix certificate contents #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
IceKhan13
reviewed
Aug 25, 2023
| @@ -303,17 +306,6 @@ data: | |||
| cpu: {{ .Values.application.ray.cpu }} | |||
| memory: {{ .Values.application.ray.memory }}Gi | |||
| securityContext: | |||
| volumeMounts: | |||
There was a problem hiding this comment.
we do not need mounts for worker anymore?
There was a problem hiding this comment.
There were 2 volumeMounts. The latter was used. This PR merges them into one.
Tansito
reviewed
Aug 28, 2023
| BASE_DIR=$1 | ||
| CLUSTER_NAME=$2 | ||
| IP_ADDRESS=$3 | ||
| NAMESPACE=$4 |
There was a problem hiding this comment.
I'm trying to understand what the pull request is doing Aki, so correct me if I'm wrong. NAMESPACE argument is not needed in this case, isn't it? At least by the script.
There was a problem hiding this comment.
You are right. The same script was used for head and worker nodes before. I separated it for the head and worker in this PR. The namespace is not used in the worker node script. I take it out. Thanks!
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
IceKhan13
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #910
Details and comments