Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ray to v2.6.3 #923

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Update dependency ray to v2.6.3 #923

merged 1 commit into from
Aug 31, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 30, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ray >=2.6.2 -> >=2.6.3 age adoption passing confidence

Release Notes

ray-project/ray (ray)

v2.6.3

Compare Source

The Ray 2.6.3 patch release contains fixes for Ray Serve, and Ray Core streaming generators.

Ray Core

🔨 Fixes:

  • [Core][Streaming Generator] Fix memory leak from the end of object stream object #​38152 (#​38206)
Ray Serve

🔨 Fixes:

RLib

📖 Documentation:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Collaborator

@akihikokuroda akihikokuroda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on m1 Mac.

@psschwei
Copy link
Collaborator

hmmm... one thing I just noticed is that the ray image uses v2.5.0:

https://github.com/Qiskit-Extensions/quantum-serverless/blob/a4a6bd51a08353a18886558080f7077d9da304f0/Dockerfile-ray-node#L3

But since we aren't using the requirements.txt file in the docker build, I don't think that change is getting picked up... we probably want to standardize on using requirements to set dependencies (or whatever #901 lands on)

@psschwei
Copy link
Collaborator

I think it's probably ok to merge this (the tests passed, so the client build should be fine) and then standardize on how we set dependency versions as part of #901

@psschwei
Copy link
Collaborator

But since we aren't using the requirements.txt file in the docker build, I don't think that change is getting picked up... we probably want to standardize on using requirements to set dependencies (or whatever #901 lands on)

Just checked, and I was wrong -- the notebook / ray images do have ray v2.6.3 ... still probably should update the dockerfile, but maybe the bot will do that after this merges...

@psschwei psschwei merged commit 1baab7b into main Aug 31, 2023
6 checks passed
@renovate renovate bot deleted the renovate/ray-2.x branch August 31, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants