Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mapping Expr values in DAG/QC converters #10226

Closed
Tracked by #10233
jakelishman opened this issue Jun 7, 2023 · 0 comments · Fixed by #10362
Closed
Tracked by #10233

Add support for mapping Expr values in DAG/QC converters #10226

jakelishman opened this issue Jun 7, 2023 · 0 comments · Fixed by #10362
Assignees
@jakelishman
Labels
type: feature request New feature or request
Milestone
0.25.0

Comments

@jakelishman
Copy link
Member

jakelishman commented Jun 7, 2023 •
edited
Loading

What should we add?

Once Expr values are valid in some .condition and .target attributes in QuantumCircuit instructions, they need to be supported through the circuit_to_dag and dag_to_circuit converters. Especially in circuit_to_dag, we must ensure that any implied classical dependencies between instructions are represented in the wires in the DAGCircuit.

The work here will mostly be in ensuring that DAGCircuit.apply_operation_back has this handling. We should also ensure that DAGCircuit.apply_operation_front has the same handling.

Depends on #10223 and #10224.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakelishman jakelishman

Labels
type: feature request New feature or request
Projects
None yet
Milestone
0.25.0
Development

Successfully merging a pull request may close this issue.

Add Expr supprt to DAGCircuit simple constructors jakelishman/qiskit-terra
1 participant
@jakelishman