Add Expr supprt to DAGCircuit simple constructors
#10362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5556084548
💛 - Coveralls |
jakelishman
force-pushed
the
expr/dag-converters
branch
2 times, most recently
from
ed65d5d
to
dce6cdd
Compare
This adds support to the `DAGCircuit` builder methods `apply_operation_front` and `apply_operation_back`, and consequently to the converter `circuit_to_dag`. This commit does not directly enhance `DAGCircuit.compose`, which will come later. The principal change is that `_bits_in_condition` is modified to the more general `_bits_in_operation`, which now accounts for both a `condition` (if set) and any additional fields from a `target` if the operation is a suitable `ControlFlowOp`. This has the effect of upgrading the converters into the `SabreDAG` format as well, but nothing is done to change the Sabre algorithms themselves.
jakelishman
force-pushed
the
expr/dag-converters
branch
from
dce6cdd
to
44976ef
Compare
|
Rebased on top of main. |
mtreinish
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support to the
DAGCircuitbuilder methodsapply_operation_frontandapply_operation_back, and consequently to the convertercircuit_to_dag. This commit does not directly enhanceDAGCircuit.compose, which will come later.The principal change is that
_bits_in_conditionis modified to the more general_bits_in_operation, which now accounts for both acondition(if set) and any additional fields from atargetif the operation is a suitableControlFlowOp. This has the effect of upgrading the converters into theSabreDAGformat as well, but nothing is done to change the Sabre algorithms themselves.Details and comments
Close #10226. Depends on #10358. Changelog to follow as part of #10331.
The change of
_bits_in_conditionto_bits_in_operationlikely does most of the remaining work for #10232 on top of its prerequisites #9419 and #9421 (although a PR for #10232 will still need to add tests).