Fix initial_layout in transpile with loose qubits
#10153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic around building a `Layout` object from an `initial_layout` was still couched in the "registers own bits" model, so could not cope with loose bits. It's most convenient to just build the mapping ourselves during the parsing, since the logic is quite specific to the form of the `initial_layout` argument, rather than being something that's inherently tied to the `Layout` class.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
kevinsung
approved these changes
May 24, 2023
Pull Request Test Coverage Report for Build 5069356780
💛 - Coveralls |
ewinston
approved these changes
May 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2023
The previous logic around building a `Layout` object from an `initial_layout` was still couched in the "registers own bits" model, so could not cope with loose bits. It's most convenient to just build the mapping ourselves during the parsing, since the logic is quite specific to the form of the `initial_layout` argument, rather than being something that's inherently tied to the `Layout` class. (cherry picked from commit 716b648)
mtreinish
pushed a commit
that referenced
this pull request
May 24, 2023
The previous logic around building a `Layout` object from an `initial_layout` was still couched in the "registers own bits" model, so could not cope with loose bits. It's most convenient to just build the mapping ourselves during the parsing, since the logic is quite specific to the form of the `initial_layout` argument, rather than being something that's inherently tied to the `Layout` class. (cherry picked from commit 716b648) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous logic around building a
Layoutobject from aninitial_layoutwas still couched in the "registers own bits" model, so could not cope with loose bits. It's most convenient to just build the mapping ourselves during the parsing, since the logic is quite specific to the form of theinitial_layoutargument, rather than being something that's inherently tied to theLayoutclass.Details and comments
Fix #10125.