Fix plot legend don't show up when dataset start with zero #10176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
|
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
added
stable backport potential
Pull Request Test Coverage Report for Build 5545829737
💛 - Coveralls |
mtreinish
approved these changes
Jul 13, 2023
|
@mtreinish no problem, I saw how many issues and PRs you had to check. Is always a pleasure work in qiskit |
mergify bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
* added test to plot_histogram with dataset starting with zero * fixed plot_histogram * added docs --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 645598a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The relative legend for a dataset didn't show up if the first value is zero. This commit just fixes this behavior, and start showing legend as expected.
Just some lines of
_plotting_corewas changed and a test was added to check if there're the expected total of legend items.Details and comments
See the issue #10158 for further information.