Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate pulse Call instruction #10247

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Deprecate pulse Call instruction #10247

merged 5 commits into from
Jun 26, 2023

Conversation

junnaka51
Copy link
Contributor

Summary

This PR intends to implement #10103 by deprecating the class qiskit.pulse.instructions.Call.

@junnaka51 junnaka51 requested review from a team, eggerdj and wshanks as code owners June 9, 2023 13:34
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 9, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @nkanazawa1989

@coveralls
Copy link

coveralls commented Jun 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5257768650

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.923%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 90.63%
qiskit/extensions/quantum_initializer/squ.py 2 80.0%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 90.18%
Totals Coverage Status
Change from base Build 5256241220: 0.02%
Covered Lines: 71310
Relevant Lines: 82993
💛 - Coveralls

@nkanazawa1989 nkanazawa1989 added Changelog: Deprecation Include in "Deprecated" section of changelog mod: pulse Related to the Pulse module labels Jun 12, 2023
@nkanazawa1989 nkanazawa1989 self-assigned this Jun 12, 2023
nkanazawa1989
nkanazawa1989 reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @junnaka51 this looks good to me. Just added a minor comment for notes.

releasenotes/notes/deprecate-pulse-Call-instruction-538802d8fad7e257.yaml Outdated Show resolved Hide resolved
nkanazawa1989
nkanazawa1989 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about my slow response. Thanks for your continuous contribution @junnaka51 !

@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Jun 26, 2023
Merged via the queue into Qiskit:main with commit d67fc2c Jun 26, 2023
@junnaka51
Copy link
Contributor Author

@nkanazawa1989 Thank you so much for your review and support again! 🙇

jlapeyre pushed a commit to ewinston/qiskit that referenced this pull request Jun 28, 2023
@junnaka51 @nkanazawa1989 @jlapeyre
Deprecate pulse Call instruction (Qiskit#10247)
ded4f96 
* deprecate pulse Call instruction

* Update releasenotes/notes/deprecate-pulse-Call-instruction-538802d8fad7e257.yaml

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>

* delete spaces in the releasenote

---------

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
@sbrandhsn sbrandhsn mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkanazawa1989 nkanazawa1989 nkanazawa1989 approved these changes

@eggerdj eggerdj Awaiting requested review from eggerdj eggerdj is a code owner

@wshanks wshanks Awaiting requested review from wshanks wshanks is a code owner

Assignees

@nkanazawa1989 nkanazawa1989

Labels
Changelog: Deprecation Include in "Deprecated" section of changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo mod: pulse Related to the Pulse module
Projects
Contributor Monitoring
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junnaka51 @qiskit-bot @coveralls @nkanazawa1989