-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruff enable a few more categories #10342
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5378031649
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logging and breakpoint ones look fine. I'd not enable the quotes one because Black already enforces it, and duplicating it risks the two tools having conflicts of opinion (Black will occasionally switch the outer quotes to reduce the number of escapes needed). We also don't use .pyi
files in Terra.
I wish ruff
would allow the descriptive names in its settings - these codes are completely illegible and I don't understand why linter designers think that this is good design.
Removed
I completely agree. They already have the unique descriptive name tags for each of these categories |
Pull Request Test Coverage Report for Build 8412014070Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Turning on:
They look helpful and the codebase already complies so no other changes needed.