Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Expr support to DAGCircuit.compose #10377

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Add Expr support to DAGCircuit.compose #10377

merged 2 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Add Expr support to DAGCircuit.compose 

    The remapping facilities are (except for some esoteric behaviour for
mapping registers to others in a different order) the same as for
`QuantumCircuit`, so it makes sense to unify the handling.  As part of
switching the old `DAGCircuit` classical-resource-mapping methods over
to the new general-purpose forms, this does most of the necessary work
to upgrade `substitute_node_with_dag` as well.
    @jakelishman
    jakelishman committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    aa50bec View commit details
    Browse the repository at this point in the history

  2. Remove exc_type argument from VariableMapper 

    Instead, we just delegate this down to a passed-in `add_register`, if
desired.  It marginally compromises the error messages that might be
emitted, but those are paths that we're hope to reduce use of anyway.
    @jakelishman
    jakelishman committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    591cbaa View commit details
    Browse the repository at this point in the history