Fix CheckMap with control-flow builder nested conditionals
#10395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursion inside the `CheckMap` pass was based on a custom `DAGCircuit.compose` solution, rather than the more standard qubit-argument-binding setup we normally use. This did not pass in the clbit ordering to the composition, which could cause it to fail to map nested conditional statements. Instead, we can just enter each DAG naturally, and use the regular wire map to access the physical indices being referred to.
jakelishman
added
Changelog: Bugfix
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5475798121
💛 - Coveralls |
jakelishman
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
The recursion inside the `CheckMap` pass was based on a custom `DAGCircuit.compose` solution, rather than the more standard qubit-argument-binding setup we normally use. This did not pass in the clbit ordering to the composition, which could cause it to fail to map nested conditional statements. Instead, we can just enter each DAG naturally, and use the regular wire map to access the physical indices being referred to. (cherry picked from commit 163875e)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
…#10397) The recursion inside the `CheckMap` pass was based on a custom `DAGCircuit.compose` solution, rather than the more standard qubit-argument-binding setup we normally use. This did not pass in the clbit ordering to the composition, which could cause it to fail to map nested conditional statements. Instead, we can just enter each DAG naturally, and use the regular wire map to access the physical indices being referred to. (cherry picked from commit 163875e) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recursion inside the
CheckMappass was based on a customDAGCircuit.composesolution, rather than the more standard qubit-argument-binding setup we normally use. This did not pass in the clbit ordering to the composition, which could cause it to fail to map nested conditional statements.Instead, we can just enter each DAG naturally, and use the regular wire map to access the physical indices being referred to.
Details and comments
Fix #10394.